Change in libosmocore[master]: BSSGP: use BVCI and NSEI as rate counter index

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Mar 11 16:52:40 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13206 )

Change subject: BSSGP: use BVCI and NSEI as rate counter index
......................................................................


Patch Set 1: Code-Review-1

I'm not sure here either.  In osmocom, the BVCI must be globally unique for each entity.  The SGSN cannot support the same BVCI on differen NS-VCs/NSEIs.  Changing the rate counter index will not make that assumption/limitation go away.  I'd prefer to keep it as-is (easily understandable counter index).  If anyone ever wants to overhaul libosmogb to support the same BVCI in multiple NSVC, then this trivial change can then be made at that time.


-- 
To view, visit https://gerrit.osmocom.org/13206
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a3ffe2fd147532f2469ec8120134ed69692fb41
Gerrit-Change-Number: 13206
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Mon, 11 Mar 2019 16:52:40 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190311/07ac0074/attachment.html>


More information about the gerrit-log mailing list