Change in osmo-ttcn3-hacks[master]: TC_rach_content(): fail test explicitly

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Mar 11 13:37:46 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13127 )

Change subject: TC_rach_content(): fail test explicitly
......................................................................

TC_rach_content(): fail test explicitly

By default Misc_Helpers.f_shutdown() will set test verdict to
'none'. Let's fail test explicitly if we had any timeouts.

Related: OS#1854
Change-Id: Ifff8b3b83eeedea0d308f7ab0bfe347e2dc278c8
---
M bts/BTS_Tests.ttcn
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 279b437..0b70da3 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1021,9 +1021,10 @@
 			}
 		}
 	}
-	if (test_failed == false) {
-		setverdict(pass);
+	if (test_failed) {
+		Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Some out of 1000 RACH requests timed out"));
 	}
+	setverdict(pass);
 	Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
 }
 

-- 
To view, visit https://gerrit.osmocom.org/13127
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifff8b3b83eeedea0d308f7ab0bfe347e2dc278c8
Gerrit-Change-Number: 13127
Gerrit-PatchSet: 4
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190311/bced6c9c/attachment.html>


More information about the gerrit-log mailing list