Change in osmo-bsc[master]: osmo_bsc_msc: Use meaningful amr rate configuration on MSC level

dexter gerrit-no-reply at lists.osmocom.org
Mon Mar 11 10:56:28 UTC 2019


dexter has posted comments on this change. ( https://gerrit.osmocom.org/13091 )

Change subject: osmo_bsc_msc: Use meaningful amr rate configuration on MSC level
......................................................................


Patch Set 3:

> I like having a more sane default.  However, that's the kind of
 > change that needs a BIG FAT warning in documentation, change log,
 > etc.  We do have users that rely on the current behavior (in fact,
 > it was implemented the current way for one of our main
 > contributors). Please make sure the manuals and TODO-RELEASE
 > mention it.

I have checked it. It works also fine with the current default configuration. I have now detached the two patches that change the default behavior from the amrmangle branch so that we can decide on them separately. However, I think its probably better to abandon the change than risking to mess things up.


-- 
To view, visit https://gerrit.osmocom.org/13091
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b2a62879755a8a5edfa1aa36c748968a56aad0d
Gerrit-Change-Number: 13091
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Mon, 11 Mar 2019 10:56:28 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190311/53d9e9d5/attachment.html>


More information about the gerrit-log mailing list