Change in osmo-mgw[master]: mgcp_network: use mgcp_rtp_codec in downlink format callback

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Mar 11 10:34:44 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13158 )

Change subject: mgcp_network: use mgcp_rtp_codec in downlink format callback
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13158/1/include/osmocom/mgcp/mgcp.h
File include/osmocom/mgcp/mgcp.h:

https://gerrit.osmocom.org/#/c/13158/1/include/osmocom/mgcp/mgcp.h@83
PS1, Line 83: struct mgcp_rtp_codec;
> why do you move mgcp_conn_rtp upwards and leave it this one here?
lol my comment was more in the direction of moving both upwards and not downwards, but fine.



-- 
To view, visit https://gerrit.osmocom.org/13158
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I348f9141eb59ed1a986447b96ab4a24ddf326936
Gerrit-Change-Number: 13158
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Mar 2019 10:34:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190311/cf51c608/attachment.html>


More information about the gerrit-log mailing list