Change in libosmocore[master]: add osmo_use_count API

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sun Mar 10 05:55:35 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13121 )

Change subject: add osmo_use_count API
......................................................................


Patch Set 2: Code-Review+1

(4 comments)

https://gerrit.osmocom.org/#/c/13121/2/include/osmocom/core/use_count.h
File include/osmocom/core/use_count.h:

https://gerrit.osmocom.org/#/c/13121/2/include/osmocom/core/use_count.h@66
PS2, Line 66: * osmo_use_count_cb_t 
Never seen such spacing style before.


https://gerrit.osmocom.org/#/c/13121/2/include/osmocom/core/use_count.h@141
PS2, Line 141:  */
Also looks a bit weird...


https://gerrit.osmocom.org/#/c/13121/2/tests/use_count/use_count_test.c
File tests/use_count/use_count_test.c:

https://gerrit.osmocom.org/#/c/13121/2/tests/use_count/use_count_test.c@320
PS2, Line 320: "use_count_test.c"
Why not __FILE__?


https://gerrit.osmocom.org/#/c/13121/2/tests/use_count/use_count_test.c@326
PS2, Line 326: log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_BASENAME);
             : 	log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE);
             : 	log_set_print_filename_pos(osmo_stderr_target, LOG_FILENAME_POS_LINE_END);
             : 	log_set_print_category(osmo_stderr_target, 1);
             : 	log_set_print_category_hex(osmo_stderr_target, 0);
             : 	log_set_print_level(osmo_stderr_target, 1);
             : 	log_set_use_color(osmo_stderr_target, 0);
Off-topic: I think we need some generic configuration for all unit tests.



-- 
To view, visit https://gerrit.osmocom.org/13121
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife31e6798b4e728a23913179e346552a7dd338c0
Gerrit-Change-Number: 13121
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sun, 10 Mar 2019 05:55:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190310/e3793ef5/attachment.html>


More information about the gerrit-log mailing list