Change in libosmo-abis[master]: Add IPA keep-alive FSM implementation

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Mar 8 18:07:49 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13196 )

Change subject: Add IPA keep-alive FSM implementation
......................................................................


Patch Set 1: Code-Review-1

(6 comments)

https://gerrit.osmocom.org/#/c/13196/1/src/input/ipa_keepalive.c
File src/input/ipa_keepalive.c:

https://gerrit.osmocom.org/#/c/13196/1/src/input/ipa_keepalive.c@132
PS1, Line 132: 	case 1:
would be perhaps nice to have an enum for T 1 and 2, so it's more descriptive: enum ipa_ka_fsm_timer { T_SEND_ANOTHER_PING = 1, T_PONG_NOT_RECEVIED };


https://gerrit.osmocom.org/#/c/13196/1/src/input/ipa_keepalive.c@138
PS1, Line 138: 		if (ifp->srv_conn)
Can probably expressed in one line: 
conn = ifp->srv_conn ? : ifp->client_conn;


https://gerrit.osmocom.org/#/c/13196/1/src/input/ipa_keepalive.c@213
PS1, Line 213: 	fi = osmo_fsm_inst_alloc(&ipa_keepalive_fsm, ctx, NULL, LOGL_DEBUG, id);
Let's merge both ipa_client and ipa_server into a static function for which you pass void* ctx, then, client or server ones are basically:

{
fi = the_static_function(client, params,id);
((*ipa_fsm_priv)(fi->priv))->client_conn = client;
return fi;
}


https://gerrit.osmocom.org/#/c/13196/1/src/input/ipa_keepalive.c@263
PS1, Line 263: /*! Start the ping/pong procedure of the IPA Keepalive FSM. */
This comment is wrong.


https://gerrit.osmocom.org/#/c/13196/1/src/input/ipa_keepalive.c@270
PS1, Line 270: /*! Stop the ping/pong procedure of the IPA Keepalive FSM. */
typo: Stop should be start.


https://gerrit.osmocom.org/#/c/13196/1/src/input/ipa_keepalive.c@277
PS1, Line 277: /*! Inform IPA Keepalive FSM that a PONG has been received. */
So basically the 3 functions comments are swapped. Good job with the mangling ;)



-- 
To view, visit https://gerrit.osmocom.org/13196
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2763da49a74de85046ac07d53592c89973314ca6
Gerrit-Change-Number: 13196
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 08 Mar 2019 18:07:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190308/8f8f234b/attachment.html>


More information about the gerrit-log mailing list