Change in osmo-ttcn3-hacks[master]: msc: as_clear_cmd_compl_disc: log unexpected message

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Mar 8 04:08:19 UTC 2019


Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13169 )

Change subject: msc: as_clear_cmd_compl_disc: log unexpected message
......................................................................

msc: as_clear_cmd_compl_disc: log unexpected message

When receiving an unexpected BSSMAP message that fails the test, log it.

Change-Id: I5cafac3318a50567f1916ea670af55558e97bf17
---
M msc/BSC_ConnectionHandler.ttcn
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn
index b041007..2cd666f 100644
--- a/msc/BSC_ConnectionHandler.ttcn
+++ b/msc/BSC_ConnectionHandler.ttcn
@@ -776,6 +776,7 @@
 }
 /* expect a clear command */
 altstep as_clear_cmd_compl_disc(float t := 5.0) runs on BSC_ConnHdlr {
+	var PDU_BSSAP bssap;
 	[] BSSAP.receive(tr_BSSMAP_ClearCommand) {
 		BSSAP.send(ts_BSSMAP_ClearComplete);
 		alt {
@@ -788,8 +789,8 @@
 			}
 		}
 		}
-	[] BSSAP.receive {
-		setverdict(fail, "Unexpected BSSMAP while waiting for ClearCommand");
+	[] BSSAP.receive(tr_BSSAP_BSSMAP) -> value bssap {
+		setverdict(fail, "Unexpected BSSMAP while waiting for ClearCommand", bssap);
 		mtc.stop;
 		}
 }

-- 
To view, visit https://gerrit.osmocom.org/13169
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cafac3318a50567f1916ea670af55558e97bf17
Gerrit-Change-Number: 13169
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190308/b5caaa59/attachment.html>


More information about the gerrit-log mailing list