Change in osmo-ttcn3-hacks[master]: msc: f_call_hangup: ignore MDCX

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Mar 7 15:39:06 UTC 2019


Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13168


Change subject: msc: f_call_hangup: ignore MDCX
......................................................................

msc: f_call_hangup: ignore MDCX

Upcoming osmo-msc changes move away from the current MDCX and Assignment
message ordering.  Depending on how far call assignment has got, there might
still be an MDCX in the message queue.

TODO should actually be handled before f_call_hangup(), right!?

Change-Id: I768f16288617aade6a4d6548129e6f9e0b1d4d33
---
M msc/BSC_ConnectionHandler.ttcn
1 file changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/13168/1

diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn
index b041007..8aace29 100644
--- a/msc/BSC_ConnectionHandler.ttcn
+++ b/msc/BSC_ConnectionHandler.ttcn
@@ -646,6 +646,10 @@
 	setverdict(pass);
 }
 
+private altstep as_optional_mgcp_mdcx() runs on BSC_ConnHdlr {
+	[] MGCP.receive(tr_MDCX) {};
+}
+
 function f_call_hangup(inout CallParameters cpars, boolean release_by_ms, boolean is_csfb := false)
 runs on BSC_ConnHdlr {
 
@@ -676,6 +680,8 @@
 
 	respond_to_dlcx := not (isbound(cpars.mgw_drop_dlcx) and valueof(cpars.mgw_drop_dlcx));
 
+	var default mdcx := activate(as_optional_mgcp_mdcx());
+
 	/* clearing of radio channel */
 	interleave {
 	[] BSSAP.receive(t_clear) {
@@ -691,6 +697,9 @@
 		}
 	}
 
+
+	deactivate(mdcx);
+
 	setverdict(pass);
 }
 

-- 
To view, visit https://gerrit.osmocom.org/13168
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I768f16288617aade6a4d6548129e6f9e0b1d4d33
Gerrit-Change-Number: 13168
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190307/a8b8cf39/attachment.html>


More information about the gerrit-log mailing list