This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13157 ) Change subject: mgcp_sdp: untangle parsing of a= parameters ...................................................................... Patch Set 1: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/13157/1/src/libosmo-mgcp/mgcp_sdp.c File src/libosmo-mgcp/mgcp_sdp.c: https://gerrit.osmocom.org/#/c/13157/1/src/libosmo-mgcp/mgcp_sdp.c@216 PS1, Line 216: else if (sscanf(line, "a=ptime:%d-%d", &ptime, &ptime2) >= 1) { this else is not needed and causes confusion. if the "if" clause is entered, then you cannot go inside the block starting in this line. https://gerrit.osmocom.org/#/c/13157/1/src/libosmo-mgcp/mgcp_sdp.c@224 PS1, Line 224: else if (sscanf(line, "a=maxptime:%d", &ptime2) == 1) { same here https://gerrit.osmocom.org/#/c/13157/1/src/libosmo-mgcp/mgcp_sdp.c@228 PS1, Line 228: break; would be nice having a comment explaining what it means reaching this line. a= parameter not supported and we simply ignore it? -- To view, visit https://gerrit.osmocom.org/13157 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc801a757e9beb6b3974863d5ee99fc7c194559e Gerrit-Change-Number: 13157 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 07 Mar 2019 14:24:10 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190307/c8ad5fc1/attachment.htm>