Change in osmo-ttcn3-hacks[master]: TC_rach_content(): log successful allocations
gerrit-no-reply at lists.osmocom.org
Thu Mar 7 10:23:08 UTC 2019
Max has posted comments on this change. ( https://gerrit.osmocom.org/13128 )
Change subject: TC_rach_content(): log successful allocations
Patch Set 2:
PS1, Line 1012: log("[", i, "] CHAN RQD FN=", fn, " RA=", ra, " OK");
> I'd argue it's not handy having 1k lines of logs of correct case.
I think it's handy and extra 2Kb of logs is hardly a big deal.
> If it fails there it can provide more info about the issue
I'd argue it's not handy having extra logs for issue which might or might not happen in future.
To view, visit https://gerrit.osmocom.org/13128
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Mar 2019 10:23:08 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log