Change in osmo-msc[master]: rename bscconfig.h to configure.h, cleanup

Max gerrit-no-reply at lists.osmocom.org
Wed Mar 6 14:32:12 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13138 )

Change subject: rename bscconfig.h to configure.h, cleanup
......................................................................


Patch Set 1:

I think mscconfig.h would be better aligned with existing bscconfig.h and btsconfig.h in other repos. Also, looking at the build failure, is there reason why it couldn't be split away from this patch series into independent patch? Or at least moved earlier in the series?


-- 
To view, visit https://gerrit.osmocom.org/13138
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4f683be1f36f0630c83da54e02868aae847aeec
Gerrit-Change-Number: 13138
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Mar 2019 14:32:12 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190306/54f0d803/attachment.html>


More information about the gerrit-log mailing list