Change in osmo-pcu[master]: Use boolean for DL resegmentation parameter

Max gerrit-no-reply at
Wed Mar 6 14:20:48 UTC 2019

Max has posted comments on this change. ( )

Change subject: Use boolean for DL resegmentation parameter

Patch Set 1:

> there is no downlink arq type "true" or "false".  While I agree i fthere are only two discrete values you should use a type with only two options, but if those optionsare not something that can be "true" or "false", using bool is just as wrong as using int, isn't it?

I'm not sure I'm following.

In 44.060 §8.1.1 there's 'resegment bit' which could be 0 (type 2 ARQ) or 1 (type 1 ARQ). So it's boolean value. That's also how it's used throughout the code so far.

In general, RLCMAC might operate in non-persistent (MBMS bearer, 43.246) acknowledged (types 1 and 2 above) and unacknowledged (no ARQ) modes according to TS 43.064 § and §

So when would we want to use some 3rd value for dl_arq_type and which spec describes that case? Or, in other words, if we make 'enum dl_arq_type', which would be the values for it besides TYPE1 and TYPE2?

Could you clarify your point with spec reference (if possible) please?

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d4fe5fe12068a4532cb3b61d4eeb229a77c1476
Gerrit-Change-Number: 13057
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at>
Gerrit-Reviewer: Daniel Willmann <dwillmann at>
Gerrit-Reviewer: Harald Welte <laforge at>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at>
Gerrit-Reviewer: osmith <osmith at>
Gerrit-Comment-Date: Wed, 06 Mar 2019 14:20:48 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list