Change in libosmocore[master]: fix tdef_test.c: do call the function-to-test in all cases

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Mar 6 06:01:06 UTC 2019


Neels Hofmeyr has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/13142 )

Change subject: fix tdef_test.c: do call the function-to-test in all cases
......................................................................

fix tdef_test.c: do call the function-to-test in all cases

Always call osmo_tdef_fsm_inst_state_chg(), also when no timeout is defined.

When there is no timeout defined for a state, tdef_test.c tries to be smart and
print different output. In that mess, I missed the fact that
osmo_tdef_fsm_inst_state_chg() isn't always called as it should. In the same
mess, the resulting state was never printed until the preceding patch, which
helped to hide this bug.

Change-Id: I1d953d99854422bff8eb32f051e9c6147bc836b6
---
M tests/tdef/tdef_test.c
M tests/tdef/tdef_test.ok
M tests/tdef/tdef_test_range_64bit.ok
3 files changed, 19 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/42/13142/2
-- 
To view, visit https://gerrit.osmocom.org/13142
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1d953d99854422bff8eb32f051e9c6147bc836b6
Gerrit-Change-Number: 13142
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190306/63b8ab2e/attachment.html>


More information about the gerrit-log mailing list