Change in osmo-pcu[master]: encoding: Fixes TMSI vs MI bit selection in repeated page info

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Mar 5 21:32:51 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13133 )

Change subject: encoding: Fixes TMSI vs MI bit selection in repeated page info
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13133/1/src/encoding.cpp
File src/encoding.cpp:

https://gerrit.osmocom.org/#/c/13133/1/src/encoding.cpp@1098
PS1, Line 1098: 	while (len) {
> Probably not an ASSERT as this is outside data (even if just the pcu sock). […]
Didn't look at surrounding code with detail, but iiuc this code is to generate a message we want to send. If this function is passed a wrong len, our code is completely broken and we should notice asap.

If we are using len coming from outside world, then whoever got that info should check it before this function.

But if you have better information do whatever you think is best :)



-- 
To view, visit https://gerrit.osmocom.org/13133
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddb00b9133f523f4ba09c8f1fc5694e62dc46fbf
Gerrit-Change-Number: 13133
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Omar Ramadan <omar.ramadan93 at gmail.com>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Mar 2019 21:32:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190305/f028194f/attachment.html>


More information about the gerrit-log mailing list