Change in osmo-gsm-tester[master]: nitb_netreg_mass: Allow a suite to configure num subscriber

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Mar 5 15:32:42 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13042 )

Change subject: nitb_netreg_mass: Allow a suite to configure num subscriber
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.osmocom.org/#/c/13042/3/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:

https://gerrit.osmocom.org/#/c/13042/3/src/osmo_gsm_tester/suite.py@341
PS3, Line 341:     def modems(self, count):
We could do the same for this method actually (see below).


https://gerrit.osmocom.org/#/c/13042/3/src/osmo_gsm_tester/suite.py@347
PS3, Line 347:     def all_modems(self):
Can we make this generic?: 
def all_resources(self, resource_func):
 ...
  l.append(resource_func())
 ...


This way we can use it for any object, ex:
suite.all_resources(suite.bts)


https://gerrit.osmocom.org/#/c/13042/3/suites/nitb_netreg_mass/register_default_mass.py
File suites/nitb_netreg_mass/register_default_mass.py:

https://gerrit.osmocom.org/#/c/13042/3/suites/nitb_netreg_mass/register_default_mass.py@20
PS3, Line 20: # Configure all MS that are availavle to this test.
avilable: typo.



-- 
To view, visit https://gerrit.osmocom.org/13042
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9fd560c2924731e4fd6eea5aaf3ad565cb4ef52
Gerrit-Change-Number: 13042
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Mar 2019 15:32:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190305/57889a8b/attachment.html>


More information about the gerrit-log mailing list