Change in osmo-pcu[master]: EDGE tests: remove no-op check

Max gerrit-no-reply at lists.osmocom.org
Tue Mar 5 11:11:02 UTC 2019


Hello Pau Espin Pedrol, Daniel Willmann, Harald Welte, osmith, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/13052

to look at the new patch set (#2).

Change subject: EDGE tests: remove no-op check
......................................................................

EDGE tests: remove no-op check

The headerTypeControl() function always return constant and is only used
inside OSMO_ASSERT() which compares it to the very same constant which
makes it no-op. Let's remove this clutter.

Change-Id: Ie0f81fe05a2b3f432de7d1f3446e8115d7524ff4
---
M src/gprs_coding_scheme.h
M tests/edge/EdgeTest.cpp
2 files changed, 0 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/52/13052/2
-- 
To view, visit https://gerrit.osmocom.org/13052
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie0f81fe05a2b3f432de7d1f3446e8115d7524ff4
Gerrit-Change-Number: 13052
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190305/3cb3b670/attachment.html>


More information about the gerrit-log mailing list