Change in libosmo-sccp[master]: add osmo_sccp_addr_cmp(), osmo_sccp_addr_ri_cmp()

Max gerrit-no-reply at lists.osmocom.org
Tue Mar 5 10:53:05 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13118 )

Change subject: add osmo_sccp_addr_cmp(), osmo_sccp_addr_ri_cmp()
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Please clarify.

https://gerrit.osmocom.org/#/c/13118/1/src/sccp_user.c
File src/sccp_user.c:

https://gerrit.osmocom.org/#/c/13118/1/src/sccp_user.c@349
PS1, Line 349: 		rc = memcmp(&a->ip.v4, &b->ip.v4, sizeof(a->ip.v4));
I'm confused - how do you use rc after setting it here?


https://gerrit.osmocom.org/#/c/13118/1/src/sccp_user.c@355
PS1, Line 355: 		rc = memcmp(&a->ip.v6, &b->ip.v6, sizeof(a->ip.v6));
Here too.


https://gerrit.osmocom.org/#/c/13118/1/src/sccp_user.c@365
PS1, Line 365: 	return 0;
Maybe you should return rc here?



-- 
To view, visit https://gerrit.osmocom.org/13118
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e2add7bbfae651c04e230d62e37cebeb91b0f5
Gerrit-Change-Number: 13118
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Mar 2019 10:53:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190305/bc9b45ba/attachment.html>


More information about the gerrit-log mailing list