Change in osmo-mgw[master]: AMR: Add option to convert between bw-effient and octet aligned mode

dexter gerrit-no-reply at lists.osmocom.org
Tue Mar 5 10:29:57 UTC 2019


dexter has posted comments on this change. ( https://gerrit.osmocom.org/13082 )

Change subject: AMR: Add option to convert between bw-effient and octet aligned mode
......................................................................


Patch Set 2:

> > what I don't like here is that this implements "blind" change
 > from
 > > one type to another type, on a global scope for the entire MGW.
 > > I'd much rather see this more fine-grained: Only on the
 > AoIP-facing
 > > connections, and only if the BSC actually asks us to. See my
 > other
 > > comment.
 > 
 > I see the problem. I will check the specs what we can do here.
 > Maybe we should even be more restrictive and configure at the BSC
 > vty which exact packet format is spoken on the AoIP side. Maybe we
 > can apply this to the HRv1 problem then as well.

There is indeed an SDP specified, which can be used to submit format specific parameters. The SDP string would look like this:

a=fmtp:97 octet-align=1

I think this is how it should be done. osmo-msc should get a VTY option and depending on this option the MGW gets instructed to apply the conversion or not.


-- 
To view, visit https://gerrit.osmocom.org/13082
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id46a3622a6b1995d5fce4bc611d409bcb4aef13b
Gerrit-Change-Number: 13082
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Mar 2019 10:29:57 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190305/48783857/attachment.html>


More information about the gerrit-log mailing list