Change in osmo-mgw[master]: AMR: Add option to convert between bw-effient and octet aligned mode
gerrit-no-reply at lists.osmocom.org
Tue Mar 5 10:29:57 UTC 2019
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13082 )
Change subject: AMR: Add option to convert between bw-effient and octet aligned mode
Patch Set 2:
> > what I don't like here is that this implements "blind" change
> > one type to another type, on a global scope for the entire MGW.
> > I'd much rather see this more fine-grained: Only on the
> > connections, and only if the BSC actually asks us to. See my
> > comment.
> I see the problem. I will check the specs what we can do here.
> Maybe we should even be more restrictive and configure at the BSC
> vty which exact packet format is spoken on the AoIP side. Maybe we
> can apply this to the HRv1 problem then as well.
There is indeed an SDP specified, which can be used to submit format specific parameters. The SDP string would look like this:
I think this is how it should be done. osmo-msc should get a VTY option and depending on this option the MGW gets instructed to apply the conversion or not.
To view, visit https://gerrit.osmocom.org/13082
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Mar 2019 10:29:57 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log