Change in docker-playground[master]: make/Makefile: allow overriding OSMO_TTCN3_BRANCH

osmith gerrit-no-reply at lists.osmocom.org
Mon Mar 4 12:14:28 UTC 2019


Hello Pau Espin Pedrol, Daniel Willmann, Max, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/13110

to look at the new patch set (#2).

Change subject: make/Makefile: allow overriding OSMO_TTCN3_BRANCH
......................................................................

make/Makefile: allow overriding OSMO_TTCN3_BRANCH

Set the OSMO_TTCN3_BRANCH build argument from ttcn3-*/Dockerfile from
the environment variable of the same name, so it can be changed when
building the images with 'make' or './jenkins.sh'.

Dockerfiles that do not have a OSMO_TCCN3_BRANCH build arg produce a
warning. But this is also the case with Dockerfiles that don't have an
USER build arg, and avoiding the warning would only be possible with a
much more complex patch.

Change-Id: If2c312ff9206d1613fc19f41bd088c9aad523684
---
M README.md
M make/Makefile
2 files changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/10/13110/2
-- 
To view, visit https://gerrit.osmocom.org/13110
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If2c312ff9206d1613fc19f41bd088c9aad523684
Gerrit-Change-Number: 13110
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190304/1fa7d08c/attachment.html>


More information about the gerrit-log mailing list