Change in osmo-mgw[master]: AMR: Add option to convert between bw-effient and octet aligned mode

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Mar 1 18:04:05 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13082 )

Change subject: AMR: Add option to convert between bw-effient and octet aligned mode
......................................................................


Patch Set 2: Code-Review-1

what I don't like here is that this implements "blind" change from one type to another type, on a global scope for the entire MGW.  I'd much rather see this more fine-grained: Only on the AoIP-facing connections, and only if the BSC actually asks us to. See my other comment.


-- 
To view, visit https://gerrit.osmocom.org/13082
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id46a3622a6b1995d5fce4bc611d409bcb4aef13b
Gerrit-Change-Number: 13082
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Fri, 01 Mar 2019 18:04:05 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190301/2249d7d3/attachment.html>


More information about the gerrit-log mailing list