Change in osmo-gsm-tester[master]: pyflakes: Remove imports of unused modules

Holger Freyther gerrit-no-reply at lists.osmocom.org
Fri Mar 1 15:08:29 UTC 2019


Holger Freyther has submitted this change and it was merged. ( https://gerrit.osmocom.org/13070 )

Change subject: pyflakes: Remove imports of unused modules
......................................................................

pyflakes: Remove imports of unused modules

Change-Id: I7496030e5857078cd66a36a5e46c9a50217ce6e3
---
M src/osmo_gsm_tester/osmo_ggsn.py
M src/osmo_gsm_tester/osmo_hlr.py
M src/osmo_gsm_tester/osmo_mgcpgw.py
M src/osmo_gsm_tester/osmo_mgw.py
M src/osmo_gsm_tester/osmo_sgsn.py
M src/osmo_gsm_tester/pcap_recorder.py
M src/osmo_gsm_tester/resource.py
M src/osmo_gsm_tester/template.py
M src/osmo_gsm_tester/util.py
9 files changed, 7 insertions(+), 18 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, approved
  Holger Freyther: Verified



diff --git a/src/osmo_gsm_tester/osmo_ggsn.py b/src/osmo_gsm_tester/osmo_ggsn.py
index 2fdc792..0ece596 100644
--- a/src/osmo_gsm_tester/osmo_ggsn.py
+++ b/src/osmo_gsm_tester/osmo_ggsn.py
@@ -20,7 +20,7 @@
 import os
 import pprint
 
-from . import log, util, config, template, process, osmo_ctrl, pcap_recorder
+from . import log, util, config, template, process, pcap_recorder
 
 class OsmoGgsn(log.Origin):
 
diff --git a/src/osmo_gsm_tester/osmo_hlr.py b/src/osmo_gsm_tester/osmo_hlr.py
index a4633e3..1c361dd 100644
--- a/src/osmo_gsm_tester/osmo_hlr.py
+++ b/src/osmo_gsm_tester/osmo_hlr.py
@@ -18,11 +18,10 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 import os
-import re
 import pprint
 import sqlite3
 
-from . import log, util, config, template, process, osmo_ctrl, pcap_recorder
+from . import log, util, config, template, process, pcap_recorder
 
 class OsmoHlr(log.Origin):
     run_dir = None
diff --git a/src/osmo_gsm_tester/osmo_mgcpgw.py b/src/osmo_gsm_tester/osmo_mgcpgw.py
index 668e4ce..20bb689 100644
--- a/src/osmo_gsm_tester/osmo_mgcpgw.py
+++ b/src/osmo_gsm_tester/osmo_mgcpgw.py
@@ -20,7 +20,7 @@
 import os
 import pprint
 
-from . import log, util, config, template, process, osmo_ctrl, pcap_recorder
+from . import log, util, config, template, process, pcap_recorder
 
 class OsmoMgcpgw(log.Origin):
 
diff --git a/src/osmo_gsm_tester/osmo_mgw.py b/src/osmo_gsm_tester/osmo_mgw.py
index 1d5596e..ca7bd51 100644
--- a/src/osmo_gsm_tester/osmo_mgw.py
+++ b/src/osmo_gsm_tester/osmo_mgw.py
@@ -20,7 +20,7 @@
 import os
 import pprint
 
-from . import log, util, config, template, process, osmo_ctrl, pcap_recorder
+from . import log, util, config, template, process, pcap_recorder
 
 class OsmoMgw(log.Origin):
 
diff --git a/src/osmo_gsm_tester/osmo_sgsn.py b/src/osmo_gsm_tester/osmo_sgsn.py
index 07cf059..9ffaaed 100644
--- a/src/osmo_gsm_tester/osmo_sgsn.py
+++ b/src/osmo_gsm_tester/osmo_sgsn.py
@@ -20,7 +20,7 @@
 import os
 import pprint
 
-from . import log, util, config, template, process, osmo_ctrl, pcap_recorder
+from . import log, util, config, template, process, pcap_recorder
 
 class OsmoSgsn(log.Origin):
 
diff --git a/src/osmo_gsm_tester/pcap_recorder.py b/src/osmo_gsm_tester/pcap_recorder.py
index 70833d0..e0f0098 100644
--- a/src/osmo_gsm_tester/pcap_recorder.py
+++ b/src/osmo_gsm_tester/pcap_recorder.py
@@ -18,11 +18,8 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 import os
-import random
-import re
-import socket
 
-from . import log, util, config, template, process, osmo_ctrl
+from . import log, process
 
 class PcapRecorder(log.Origin):
 
diff --git a/src/osmo_gsm_tester/resource.py b/src/osmo_gsm_tester/resource.py
index 4f48dc4..29f641e 100644
--- a/src/osmo_gsm_tester/resource.py
+++ b/src/osmo_gsm_tester/resource.py
@@ -18,7 +18,6 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 import os
-import time
 import copy
 import atexit
 import pprint
@@ -27,8 +26,6 @@
 from . import config
 from . import util
 from . import schema
-from . import modem
-from . import osmo_nitb
 from . import bts_sysmo, bts_osmotrx, bts_osmovirtual, bts_octphy, bts_nanobts
 
 from .util import is_dict, is_list
diff --git a/src/osmo_gsm_tester/template.py b/src/osmo_gsm_tester/template.py
index 0ddfc84..c890963 100644
--- a/src/osmo_gsm_tester/template.py
+++ b/src/osmo_gsm_tester/template.py
@@ -18,8 +18,7 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-import os, sys
-from mako.template import Template
+import os
 from mako.lookup import TemplateLookup
 
 from . import log
diff --git a/src/osmo_gsm_tester/util.py b/src/osmo_gsm_tester/util.py
index 27c71cf..930c86a 100644
--- a/src/osmo_gsm_tester/util.py
+++ b/src/osmo_gsm_tester/util.py
@@ -27,9 +27,6 @@
 import atexit
 import threading
 import importlib.util
-import fcntl
-import tty
-import readline
 import subprocess
 
 # This mirrors enum osmo_auth_algo in libosmocore/include/osmocom/crypt/auth.h

-- 
To view, visit https://gerrit.osmocom.org/13070
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7496030e5857078cd66a36a5e46c9a50217ce6e3
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190301/e4e485f6/attachment.html>


More information about the gerrit-log mailing list