Change in ...osmo-trx[master]: Transceiver: refactor: gather uplink burst parameters in struct

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jun 30 07:16:14 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14630 )

Change subject: Transceiver: refactor: gather uplink burst parameters in struct
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/14630/2/Transceiver52M/Transceiver.h 
File Transceiver52M/Transceiver.h:

https://gerrit.osmocom.org/#/c/14630/2/Transceiver52M/Transceiver.h@274 
PS2, Line 274: struct trx_ul_burst_ind *bi
cosmetic: const


https://gerrit.osmocom.org/#/c/14630/2/Transceiver52M/Transceiver.cpp 
File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/#/c/14630/2/Transceiver52M/Transceiver.cpp@562 
PS2, Line 562: rssi_valid
Do you think we still need this? I think, if the function returns false, then the caller should consider the 'trx_ul_burst_ind' structure as uninitialized. Moreover, RSSI is mandatory - we cannot send burst indications without it.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14630
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I7e590fb1c0901de627e782f183251c20f4f68d48
Gerrit-Change-Number: 14630
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Sun, 30 Jun 2019 07:16:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190630/550ac859/attachment.html>


More information about the gerrit-log mailing list