Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jun 30 07:05:31 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 )

Change subject: Introduce structs to encode TRXD packets
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/14629/2/Transceiver52M/Transceiver.cpp 
File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/#/c/14629/2/Transceiver52M/Transceiver.cpp@957 
PS2, Line 957: pkt
I think you also need to initialize the pkt->version here. Otherwise we are sending garbage?


https://gerrit.osmocom.org/#/c/14629/2/Transceiver52M/Transceiver.cpp@967 
PS2, Line 967: There's an uninitizalied
Actually, there are two bytes. One is being initialized here, another is also being sent but not initialized.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14629
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb
Gerrit-Change-Number: 14629
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Sun, 30 Jun 2019 07:05:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190630/f2f575b1/attachment.html>


More information about the gerrit-log mailing list