Change in ...osmo-trx[master]: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts

pespin gerrit-no-reply at lists.osmocom.org
Fri Jun 28 15:46:58 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14632


Change subject: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts
......................................................................

Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts

Those 2 bytes at the end have been sent over the TRXD socket for
historical reasons. However, osmo-bts-trx also supports receiving bursts
without that padding for quite a while now, so let's drop those two
(since anyway those are not going to be sent for sure in v1 of TRXD
protocol).

Related: OS#4006
Change-Id: Iedc54011f333f48c6c8b81cab4d640f7601e01dd
---
M Transceiver52M/Transceiver.cpp
1 file changed, 1 insertion(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/32/14632/1

diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index c7e213a..ff768ac 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -952,11 +952,9 @@
   for (unsigned i = 0; i < bi.nbits; i++)
     pkt->soft_bits[i] = (char) round((*burstItr++) * 255.0);
 
-  /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi.nbits] */
-  pkt->soft_bits[bi.nbits + 1] = '\0';
   delete bi.rxBurst;
 
-  mDataSockets[chan]->write(burstString, sizeof(struct trxd_hdr_v0) + bi.nbits + 2);
+  mDataSockets[chan]->write(burstString, sizeof(struct trxd_hdr_v0) + bi.nbits);
 }
 
 void Transceiver::driveTxFIFO()

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14632
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Iedc54011f333f48c6c8b81cab4d640f7601e01dd
Gerrit-Change-Number: 14632
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190628/6910d74d/attachment.html>


More information about the gerrit-log mailing list