Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets

pespin gerrit-no-reply at lists.osmocom.org
Fri Jun 28 15:34:25 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 )

Change subject: Introduce structs to encode TRXD packets
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14629/1/Transceiver52M/Transceiver.cpp 
File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/#/c/14629/1/Transceiver52M/Transceiver.cpp@967 
PS1, Line 967:   pkt->soft_bits[nbits] = '\0';
> Here I actually introduced a change, and to me wrong version looks "wrong", since it's leaving one b […]
Ah those seem to be the famous "historically 2 bytes are added at the end". So now osmo-bts-trx cries because it's neither X nor X+2, but X+1. I'll re-submit the patch keeping the hole there.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14629
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb
Gerrit-Change-Number: 14629
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jun 2019 15:34:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190628/4bfca332/attachment.html>


More information about the gerrit-log mailing list