Change in ...osmo-ttcn3-hacks[master]: mgw: add module param mp_enable_conn_timeout_test

osmith gerrit-no-reply at lists.osmocom.org
Fri Jun 28 09:34:40 UTC 2019


osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14627


Change subject: mgw: add module param mp_enable_conn_timeout_test
......................................................................

mgw: add module param mp_enable_conn_timeout_test

Fix ttcn3-mgw-latest by not running "conn-timeout 0" during f_init_vty
at the start of every test case. The latest osmo-mgw release does not
have that command yet.

Change-Id: I8bbf15baa45679d5812a5a9184520ef9b9e73bba
---
M mgw/MGCP_Test.ttcn
1 file changed, 10 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/27/14627/1

diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index aeb6ef8..7ddb6ea 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -69,6 +69,10 @@
 		charstring mp_remote_ip := "127.0.0.1";
 		PortNumber mp_local_rtp_port_base := 10000;
 		PortNumber mp_local_osmux_port := 1985;
+
+		/* Whether to enable conn-timeout tests. Can be dropped completely and enabled unconditionally once new
+		 * version of osmo-mgw is released (current version: 1.5.0) */
+		boolean mp_enable_conn_timeout_test := true;
 	}
 
 	private function f_vty_enable_osmux(boolean osmux_on) runs on dummy_CT {
@@ -91,7 +95,9 @@
 		f_vty_transceive(MGWVTY, "enable");
 
 		f_vty_enable_osmux(osmux_on);
-		f_vty_config(MGWVTY, "mgcp", "conn-timeout 0");
+		if (mp_enable_conn_timeout_test) {
+			f_vty_config(MGWVTY, "mgcp", "conn-timeout 0");
+		}
 	}
 
 	private function f_rtpem_init(inout RTP_Emulation_CT comp_ref, integer i)
@@ -2158,6 +2164,8 @@
 		execute(TC_amr_oa_oa_rtp_conversion());
 		execute(TC_amr_bwe_bwe_rtp_conversion());
 
-		execute(TC_conn_timeout());
+		if (mp_enable_conn_timeout_test) {
+			execute(TC_conn_timeout());
+		}
 	}
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14627
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8bbf15baa45679d5812a5a9184520ef9b9e73bba
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190628/2400669f/attachment.html>


More information about the gerrit-log mailing list