Change in ...osmo-ttcn3-hacks[master]: mgw: move 'conn-timeout 0' out of f_init

osmith gerrit-no-reply at lists.osmocom.org
Thu Jun 27 13:35:47 UTC 2019


osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14617


Change subject: mgw: move 'conn-timeout 0' out of f_init
......................................................................

mgw: move 'conn-timeout 0' out of f_init

Do not break all ttcn3-mgw-latest tests by using a command in f_init,
which isn't available in latest yet [1].

I thought about keeping it in f_init, and adding a setting to not use
this VTY command in -latest like done in [2]. But then we also need to
touch osmo-ci.git and remember to switch it back once the next version
is released. This does not seem to be worth it for just this one test,
let's rather have it working automatically once the next version is
released.

[1] I7dee7dafaaf4bb93fd692ea06b52b9e012beac6d
[2] I53d58b2d905905ebf1df322d0389b3715a48212f

Change-Id: Idcbe9178ee3324953c88233f5f7d79672e9639db
---
M mgw/MGCP_Test.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/14617/1

diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index aeb6ef8..cd2b66e 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -91,7 +91,6 @@
 		f_vty_transceive(MGWVTY, "enable");
 
 		f_vty_enable_osmux(osmux_on);
-		f_vty_config(MGWVTY, "mgcp", "conn-timeout 0");
 	}
 
 	private function f_rtpem_init(inout RTP_Emulation_CT comp_ref, integer i)
@@ -2102,6 +2101,7 @@
 		f_rtpem_conn_refuse_verify(RTPEM[0]);
 
 		setverdict(pass);
+		f_vty_config(MGWVTY, "mgcp", "conn-timeout 0");
 	}
 
 	control {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14617
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idcbe9178ee3324953c88233f5f7d79672e9639db
Gerrit-Change-Number: 14617
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190627/5dab3f2b/attachment.html>


More information about the gerrit-log mailing list