Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: add basic TRXD version 0x01 support

pespin gerrit-no-reply at lists.osmocom.org
Thu Jun 27 09:33:35 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14585 )

Change subject: trx_toolkit/fake_trx.py: add basic TRXD version 0x01 support
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/14585/2/src/target/trx_toolkit/ctrl_if_trx.py 
File src/target/trx_toolkit/ctrl_if_trx.py:

https://gerrit.osmocom.org/#/c/14585/2/src/target/trx_toolkit/ctrl_if_trx.py@151 
PS2, Line 151: 		if self.verify_cmd(request, "SETVER", 1):
SETVER? SETFORMAT?


https://gerrit.osmocom.org/#/c/14585/2/src/target/trx_toolkit/data_if.py 
File src/target/trx_toolkit/data_if.py:

https://gerrit.osmocom.org/#/c/14585/2/src/target/trx_toolkit/data_if.py@53 
PS2, Line 53: 		return None
return False



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14585
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I164f5ae4ce7694d6e324aab927a04e96d489ebd8
Gerrit-Change-Number: 14585
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Jun 2019 09:33:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190627/7393d93e/attachment.html>


More information about the gerrit-log mailing list