Change in ...osmo-mgw[master]: vty: allow 0 as conn-timeout to disable it

osmith gerrit-no-reply at lists.osmocom.org
Thu Jun 27 07:23:39 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14601 )

Change subject: vty: allow 0 as conn-timeout to disable it
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

Thanks for all the reviews!

> Is there any 'mgcp_vty_reference.xml'? If yes, please also update it.

I'll do that in a follow-up patch.

Giving +2, because of >2x +1 (see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit#Voting-Rules-for-merging-a-patch-to-master ).

https://gerrit.osmocom.org/#/c/14601/1/src/libosmo-mgcp/mgcp_vty.c 
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/#/c/14601/1/src/libosmo-mgcp/mgcp_vty.c@1392 
PS1, Line 1392: DEFUN(cfg_mgcp_no_conn_timeout,
> We should agree on one way to do it, because "no e1_line 0 keepalive" is still what libosmo-abis wan […]
I would also like to have this consistent, but unfortunately we have both versions already. Here are two examples of <0-...:

 osmo-hlr/src/hlr_vty.c:        "ncss-guard-timeout <0-255>",
 osmo-msc/src/libmsc/msc_vty.c:      "mncc guard-timeout <0-255>",

So I'll go with the <0-... version here instead of changing it again.

Maybe it makes sense to propose a standard way of doing it (on the ML) and then deprecating the other one?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I7dee7dafaaf4bb93fd692ea06b52b9e012beac6d
Gerrit-Change-Number: 14601
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Jun 2019 07:23:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Comment-In-Reply-To: Hoernchen <ewild at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190627/1516d98a/attachment.html>


More information about the gerrit-log mailing list