Change in ...osmo-bsc[master]: bsc_subscr_conn_fsm: Use gscon_bssmap_clear() helper on send failure

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 27 01:17:49 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14607 )

Change subject: bsc_subscr_conn_fsm: Use gscon_bssmap_clear() helper on send failure
......................................................................

bsc_subscr_conn_fsm: Use gscon_bssmap_clear() helper on send failure

Change-Id: I45b42b76c260a5bac416ad3a5761918a8ab59f86
---
M src/osmo-bsc/bsc_subscr_conn_fsm.c
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index 7b9f912..0830dee 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -984,7 +984,6 @@
 {
 	uint8_t sapi;
 	int rc;
-	struct msgb *resp = NULL;
 
 	if (!conn->lchan) {
 		LOGP(DMSC, LOGL_ERROR,
@@ -1027,8 +1026,7 @@
 
 failed_to_send:
 	LOGPFSML(conn->fi, LOGL_ERROR, "Tx BSSMAP CLEAR REQUEST to MSC\n");
-	resp = gsm0808_create_clear_rqst(GSM0808_CAUSE_EQUIPMENT_FAILURE);
-	gscon_sigtran_send(conn, resp);
+	gscon_bssmap_clear(conn, GSM0808_CAUSE_EQUIPMENT_FAILURE);
 	osmo_fsm_inst_state_chg(conn->fi, ST_ACTIVE, 0, 0);
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14607
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I45b42b76c260a5bac416ad3a5761918a8ab59f86
Gerrit-Change-Number: 14607
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190627/a5245420/attachment.html>


More information about the gerrit-log mailing list