Change in ...osmo-mgw[master]: vty: allow 0 as conn-timeout to disable it

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Wed Jun 26 14:21:48 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14601 )

Change subject: vty: allow 0 as conn-timeout to disable it
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14601/1/src/libosmo-mgcp/mgcp_vty.c 
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/#/c/14601/1/src/libosmo-mgcp/mgcp_vty.c@1392 
PS1, Line 1392: DEFUN(cfg_mgcp_no_conn_timeout,
> In my opinion in this case I think it makes sense to simply extend the exiting "conn-timeout" above  […]
I've added zero as value, but not documented explicitly that it disables the timeout. Do you think we need to state that explicitly?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I7dee7dafaaf4bb93fd692ea06b52b9e012beac6d
Gerrit-Change-Number: 14601
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Jun 2019 14:21:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190626/f042f69b/attachment.htm>


More information about the gerrit-log mailing list