Change in ...osmo-mgw[master]: vty: add "no conn-timeout"

pespin gerrit-no-reply at lists.osmocom.org
Wed Jun 26 12:24:25 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14601 )

Change subject: vty: add "no conn-timeout"
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14601/1/src/libosmo-mgcp/mgcp_vty.c 
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/#/c/14601/1/src/libosmo-mgcp/mgcp_vty.c@1392 
PS1, Line 1392: DEFUN(cfg_mgcp_no_conn_timeout,
In my opinion in this case I think it makes sense to simply extend the exiting "conn-timeout" above to support receiving 0, and documenting there that 0 is used to disable it. Using 0 to disable a timeout is quite a usual thing and expected by users imho.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I7dee7dafaaf4bb93fd692ea06b52b9e012beac6d
Gerrit-Change-Number: 14601
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Jun 2019 12:24:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190626/bff6e357/attachment.html>


More information about the gerrit-log mailing list