Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: use osmo_loadXXbe() for TDMA FN and ToA256

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jun 26 09:08:37 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14591 )

Change subject: osmo-bts-trx/trx_if.c: use osmo_loadXXbe() for TDMA FN and ToA256
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/14591/1/src/osmo-bts-trx/trx_if.c 
File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/#/c/14591/1/src/osmo-bts-trx/trx_if.c@43 
PS1, Line 43: #include <osmocom/core/bit32gen.h>
> I think you should include #include <osmocom/core/bits.h> instead.
ACK, thanks!


https://gerrit.osmocom.org/#/c/14591/1/src/osmo-bts-trx/trx_if.c@617 
PS1, Line 617: 	fn =  osmo_load32be(buf + 1);
> Can we use array offsets instead of mixing them with pointer arithmetic? […]
Heh, I expected your comment as you're always against using pointer arithmetic ;)

What's wrong with pointer arithmetic? IMHO, this looks quite clean: load 32-bit integer skipping one byte. I don't see anything against that in our coding standards [1]. Neither I see any benefits besides personal preferences.

[1] https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14591
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iec0d86f9be7243578ddc1ab322fc313cb5ac5d0b
Gerrit-Change-Number: 14591
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Jun 2019 09:08:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190626/98b0e109/attachment.html>


More information about the gerrit-log mailing list