Change in ...osmo-python-tests[master]: osmo_trap2cgi.py: Don't recurse in ctrl_client()

msuraev gerrit-no-reply at lists.osmocom.org
Mon Jun 24 16:10:13 UTC 2019


msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/14545 )

Change subject: osmo_trap2cgi.py: Don't recurse in ctrl_client()
......................................................................


Patch Set 2:

(1 comment)

Looks good overall but I can't test it of course.
The only thing I'd recommend is to bump the version so it'd be obvious whether you're using recursion or loop code.

https://gerrit.osmocom.org/#/c/14545/1/scripts/osmo_trap2cgi.py 
File scripts/osmo_trap2cgi.py:

https://gerrit.osmocom.org/#/c/14545/1/scripts/osmo_trap2cgi.py@215 
PS1, Line 215:         await conn_client(proxy)
> Yes, see also my generic comment. So I'll try to get the recursion out of this script. […]
Nothing special, the recursion variant seems easier to review/understand.



-- 
To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/14545
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: Ic909e371771f3056cb87e18793fd4225ffb90a2c
Gerrit-Change-Number: 14545
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: msuraev <suraev at alumni.ntnu.no>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Jun 2019 16:10:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190624/0668e467/attachment.html>


More information about the gerrit-log mailing list