Change in ...osmo-pcu[master]: rlc: replace int with uint16_t

laforge gerrit-no-reply at lists.osmocom.org
Mon Jun 24 13:48:09 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14569 )

Change subject: rlc: replace int with uint16_t
......................................................................

rlc: replace int with uint16_t

The i value will only count forward and is limited to 11 bit. The integer is also
converted when returning to uint16_t

Change-Id: Ib8a9081bbcb8b4344498254c58941002d17f9381
---
M src/rlc.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/rlc.cpp b/src/rlc.cpp
index e5067c9..c6d4330 100644
--- a/src/rlc.cpp
+++ b/src/rlc.cpp
@@ -91,7 +91,7 @@
 /* Update the receive block bitmap */
 uint16_t gprs_rlc_ul_window::update_egprs_rbb(uint8_t *rbb)
 {
-	int i;
+	uint16_t i;
 	uint16_t bsn;
 	uint16_t bitmask = 0x80;
 	int8_t pos = 0;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14569
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ib8a9081bbcb8b4344498254c58941002d17f9381
Gerrit-Change-Number: 14569
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190624/332da204/attachment.html>


More information about the gerrit-log mailing list