Change in ...osmo-pcu[master]: decompress_crbb: replace int8_t with uint8_t as length

fixeria gerrit-no-reply at lists.osmocom.org
Sat Jun 22 08:12:25 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14480 )

Change subject: decompress_crbb: replace int8_t with uint8_t as length
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/14480/1/src/egprs_rlc_compression.cpp 
File src/egprs_rlc_compression.cpp:

https://gerrit.osmocom.org/#/c/14480/1/src/egprs_rlc_compression.cpp@512 
PS1, Line 512: while (compress_bmap_len > 0)
So this condition becomes meaningless.


https://gerrit.osmocom.org/#/c/14480/1/src/egprs_rlc_compression.cpp@539 
PS1, Line 539: compress_bmap_len = compress_bmap_len - nbits;
... and here we can get unexpected results.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14480
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7099bff92eba3bf4db8601a2575c721e2579ce8e
Gerrit-Change-Number: 14480
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 22 Jun 2019 08:12:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190622/79fecd37/attachment.html>


More information about the gerrit-log mailing list