Change in ...osmo-bts[master]: bts: Set T200 DCCH values for CCCH

pespin gerrit-no-reply at lists.osmocom.org
Fri Jun 21 17:08:31 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14568


Change subject: bts: Set T200 DCCH values for CCCH
......................................................................

bts: Set T200 DCCH values for CCCH

Otherwise t200_ms_dcch array values are left uninitialized with random
values, and passed later on to lapdm_channel_init2().

Catched due to some strange values seen in log (see D0 and D3):
osmo-bts/src/common/bts.c:421 (bts=0,trx=0,ts=0,ss=4) Setting T200 D0=1028672, D3=2, S0=520, S3=520 (all in ms)

There doesn't seem to be any related field passed by BSC to specifically
set T200 for this chan type, so let's use the one from SDCCH.

Related: OS#4066
Change-Id: I3d7e1883811acf97aac97325739f2ff97fc2aa08
---
M src/common/bts.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/68/14568/1

diff --git a/src/common/bts.c b/src/common/bts.c
index b912f33..80c7834 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -392,6 +392,7 @@
 	t200_ms_acch[DL_SAPI3] = bts->t200_ms[T200_SACCH_SDCCH] + fn_advance_ms;
 
 	switch (lchan->type) {
+	case GSM_LCHAN_CCCH:
 	case GSM_LCHAN_SDCCH:
 		t200_ms_dcch[DL_SAPI0] = bts->t200_ms[T200_SDCCH] + fn_advance_ms;
 		t200_ms_dcch[DL_SAPI3] = bts->t200_ms[T200_SDCCH_SAPI3] + fn_advance_ms;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14568
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3d7e1883811acf97aac97325739f2ff97fc2aa08
Gerrit-Change-Number: 14568
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190621/f2af9323/attachment.html>


More information about the gerrit-log mailing list