Change in ...docker-playground[master]: ttcn3-hlr-test: log to file and gsmtap

osmith gerrit-no-reply at lists.osmocom.org
Fri Jun 21 12:59:00 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14563 )

Change subject: ttcn3-hlr-test: log to file and gsmtap
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14563/2/ttcn3-hlr-test/osmo-hlr.cfg 
File ttcn3-hlr-test/osmo-hlr.cfg:

https://gerrit.osmocom.org/#/c/14563/2/ttcn3-hlr-test/osmo-hlr.cfg@24 
PS2, Line 24: log gsmtap 172.18.10.103
> I personally don't like having log in gsmtap, and I think we are not doing that in any test so far,  […]
Is there any downside to having gsmtap in tests? I find it useful to have the logs in the same pcap file as the trace of the test, and if somebody gets distracted from it, they could simply filter it away in the wireshark UI.

I agree that having it the same for every test suite would be best.



-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14563
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ifb4a39e6e2987f4dc04369508fe0dff0913a02ff
Gerrit-Change-Number: 14563
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Jun 2019 12:59:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190621/6033cda9/attachment.html>


More information about the gerrit-log mailing list