Change in ...openbsc[master]: bsc-nat: Remove whitespace at the end of CTR descriptions

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 20 16:57:15 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14539 )

Change subject: bsc-nat: Remove whitespace at the end of CTR descriptions
......................................................................


Patch Set 1: Code-Review+1

IIRC this was the style that back then Jacob preferred to use.  IIRC the goal was to use this as a hack for proper indenting in vty display of the counteres. I always found it highly questionable, but I'm not sure if we have users that base on that assumption by now? But yes, I'm in favour of it.  The vty code should take care of indenting/formatting, e.g. by iterating the counters names twice: once to determine the longest string (and hence indent level), and then use that information to properly format it in the second run.


-- 
To view, visit https://gerrit.osmocom.org/c/openbsc/+/14539
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia7ff352de1fb1997066f72e84a7d517c7642853a
Gerrit-Change-Number: 14539
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Thu, 20 Jun 2019 16:57:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190620/d6d2597d/attachment.html>


More information about the gerrit-log mailing list