Change in ...osmo-python-tests[master]: osmo_trap2cgi.py: Don't recurse in ctrl_client()

daniel gerrit-no-reply at lists.osmocom.org
Wed Jun 19 16:07:35 UTC 2019


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/14545 )

Change subject: osmo_trap2cgi.py: Don't recurse in ctrl_client()
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/14545/1/scripts/osmo_trap2cgi.py 
File scripts/osmo_trap2cgi.py:

https://gerrit.osmocom.org/#/c/14545/1/scripts/osmo_trap2cgi.py@193 
PS1, Line 193:         await conn_client(proxy)
We need to break this recursion as well.


https://gerrit.osmocom.org/#/c/14545/1/scripts/osmo_trap2cgi.py@215 
PS1, Line 215:         await conn_client(proxy)
> Then we should turn this recursion into a while True.
Yes, see also my generic comment. So I'll try to get the recursion out of this script. Maybe Max can share his ideas why he used it in the first place.



-- 
To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/14545
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: Ic909e371771f3056cb87e18793fd4225ffb90a2c
Gerrit-Change-Number: 14545
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <suraev at alumni.ntnu.no>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Jun 2019 16:07:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190619/447b326a/attachment.html>


More information about the gerrit-log mailing list