Change in ...docker-playground[master]: regen_doc.sh: Add optional parameter to customize docker execution

daniel gerrit-no-reply at lists.osmocom.org
Wed Jun 19 12:47:53 UTC 2019


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14527 )

Change subject: regen_doc.sh: Add optional parameter to customize docker execution
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14527/2/scripts/regen_doc.sh 
File scripts/regen_doc.sh:

https://gerrit.osmocom.org/#/c/14527/2/scripts/regen_doc.sh@28 
PS2, Line 28: 		${DOCKER_EXTRA}
> not sure if we need "" here.
I don't think so. I'm using it with DOCKER_EXTRA="osmo-bsc_nat -c /data/osmo-bsc_nat.cfg" and in docker run these should (or at least can) be independent arguments.

ttcn3-bscnat-test calls docker run like this as well.

docker run      --rm \
                --network $NET_NAME --ip 172.18.15.20 \
                -v $VOL_BASE_DIR/bscnat:/data \
                --name ${BUILD_TAG}-bscnat -d \
                $REPO_USER/osmo-nitb-$IMAGE_SUFFIX osmo-bsc_nat -c /data/osmo-bsc-nat.cfg



-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14527
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I52c3cb2cdcfb143e71ac2c1aa40bb466e41a0f5c
Gerrit-Change-Number: 14527
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Jun 2019 12:47:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190619/587342f1/attachment.html>


More information about the gerrit-log mailing list