Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: inform HLR/EUSE if Paging has failed

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jun 17 14:37:54 UTC 2019


fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14475 )

Change subject: libmsc/gsm_09_11.c: inform HLR/EUSE if Paging has failed
......................................................................

libmsc/gsm_09_11.c: inform HLR/EUSE if Paging has failed

Change-Id: Ie2ac06aadb18251310e0cfd85bb0d9865470aab7
Related: (TTCN-3) I1f53c56d569c8ac4071835685bbe3bc9e0ebd7f0
Related: OS#2931
---
M src/libmsc/gsm_09_11.c
1 file changed, 17 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved



diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c
index 51cb2fb..f58c106 100644
--- a/src/libmsc/gsm_09_11.c
+++ b/src/libmsc/gsm_09_11.c
@@ -297,9 +297,25 @@
 		/* Count established network-initiated NC SS/USSD sessions */
 		rate_ctr_inc(&net->msc_ctrs->ctr[MSC_CTR_NC_SS_MT_ESTABLISHED]);
 	} else {
+		struct osmo_gsup_message gsup_msg;
+
 		LOG_MSC_A_CAT(msc_a, DSS, LOGL_DEBUG, "Paging expired\n");
 
-		/* TODO: inform HLR about this failure */
+		gsup_msg = (struct osmo_gsup_message){
+			.message_class = OSMO_GSUP_MESSAGE_CLASS_USSD,
+			.message_type = OSMO_GSUP_MSGT_PROC_SS_ERROR,
+
+			.session_state = OSMO_GSUP_SESSION_STATE_END,
+			.session_id = trans->callref,
+			/* FIXME: we need message class specific cause values */
+			.cause = GMM_CAUSE_IMPL_DETACHED,
+		};
+
+		/* Fill in subscriber's IMSI */
+		OSMO_STRLCPY_ARRAY(gsup_msg.imsi, trans->vsub->imsi);
+
+		/* Inform HLR/EUSE about the failure */
+		gsup_client_mux_tx(trans->net->gcm, &gsup_msg);
 
 		msgb_free(trans->ss.msg);
 		trans->ss.msg = NULL;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14475
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie2ac06aadb18251310e0cfd85bb0d9865470aab7
Gerrit-Change-Number: 14475
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190617/9ed150fe/attachment.html>


More information about the gerrit-log mailing list