Change in ...osmo-pcu[master]: decompress_crbb: add length argument for search_runlen

lynxis lazus gerrit-no-reply at lists.osmocom.org
Mon Jun 17 11:54:45 UTC 2019


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14481 )

Change subject: decompress_crbb: add length argument for search_runlen
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14481/1/src/egprs_rlc_compression.cpp 
File src/egprs_rlc_compression.cpp:

https://gerrit.osmocom.org/#/c/14481/1/src/egprs_rlc_compression.cpp@471 
PS1, Line 471: 	while (iter->run_length == -1) {
> Why is iterating over this condition which seems to never change inside the loop? That's really conf […]
it's walking over a tree. branches have run_length = -1, while leafs have a runlength >= 0



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14481
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ie34a0651e7e7efea4e9ecff1e3a467588113cf47
Gerrit-Change-Number: 14481
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Jun 2019 11:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190617/69e39341/attachment.html>


More information about the gerrit-log mailing list