Change in ...osmo-trx[master]: Add option to set stack size in config file, default == 0 == OS default

Hoernchen gerrit-no-reply at lists.osmocom.org
Mon Jun 17 11:49:01 UTC 2019


Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14488 )

Change subject: Add option to set stack size in config file, default == 0 == OS default
......................................................................


Patch Set 1:

(3 comments)

> Patch Set 1: Code-Review+1
> 
> (5 comments)
> 
> Fine, small fixes needed.

https://gerrit.osmocom.org/#/c/14488/1/CommonLibs/trx_vty.h 
File CommonLibs/trx_vty.h:

https://gerrit.osmocom.org/#/c/14488/1/CommonLibs/trx_vty.h@66 
PS1, Line 66: 		unsigned int stack_size;
> size_t?
Why? Real range is from not enough (32k) to default on linux (8MiB) to ... slightly more, which is extremely unlikely, it just has to be a type that can hold a reasonably large number.


https://gerrit.osmocom.org/#/c/14488/1/CommonLibs/trx_vty.c 
File CommonLibs/trx_vty.c:

https://gerrit.osmocom.org/#/c/14488/1/CommonLibs/trx_vty.c@340 
PS1, Line 340: 	"stack-size <0-2147483647>",
> is 2147483647 or something similar? worth adding a comment.
Doesn't matter, no one is going to increase the stack size from 8MiB to 2GiB, i could have chosen 12345678 instead.


https://gerrit.osmocom.org/#/c/14488/1/CommonLibs/trx_vty.c@685 
PS1, Line 685: 	trx->cfg.stack_size = 0;
> You can drop this line, it's already set by talloc_zero.
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14488
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Id752f6b5ce9a96a67cd1ff835687ce0e03d3a50d
Gerrit-Change-Number: 14488
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Jun 2019 11:49:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190617/ae8e1ba7/attachment.html>


More information about the gerrit-log mailing list