Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: do not abuse LOG_TRANS() and early trans allocation

pespin gerrit-no-reply at lists.osmocom.org
Mon Jun 17 08:59:00 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14463 )

Change subject: libmsc/gsm_09_11.c: do not abuse LOG_TRANS() and early trans allocation
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/14463/3/src/libmsc/gsm_09_11.c 
File src/libmsc/gsm_09_11.c:

https://gerrit.osmocom.org/#/c/14463/3/src/libmsc/gsm_09_11.c@325 
PS3, Line 325: 	LOGP(DSS, LOGL_DEBUG, "Establishing a network-originated session (id=0x%x) "
Can we emulate format of LOG_TRANS() here? Like:
"(%S) stablishing a network-originated session (id=0x%x)"
or something similar.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14463
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4e027b19e8065a39324a1647957cef4066b82ce7
Gerrit-Change-Number: 14463
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Jun 2019 08:59:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190617/734d4aec/attachment.html>


More information about the gerrit-log mailing list