Change in ...libosmocore[master]: Revert "fsm.c: Print error message for FSM with allstate_action but n...

laforge gerrit-no-reply at lists.osmocom.org
Sat Jun 15 18:41:29 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14473 )

Change subject: Revert "fsm.c: Print error message for FSM with allstate_action but no events"
......................................................................

Revert "fsm.c: Print error message for FSM with allstate_action but no events"

This reverts commit b3f94eb39e19366c3458643ee329a73155d46ff8, that
unfortunately breaks some projects which call osmo_fsm_register()
on DSO load (i.e. using __attribute__((constructor))) before the
logging is initialized.

Change-Id: Idc6fcce7e946c23d48589b920e309d60aa7b6645
---
M src/fsm.c
1 file changed, 0 insertions(+), 11 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/fsm.c b/src/fsm.c
index 04c583b..337786d 100644
--- a/src/fsm.c
+++ b/src/fsm.c
@@ -256,17 +256,6 @@
 		return -EEXIST;
 	if (fsm->event_names == NULL)
 		LOGP(DLGLOBAL, LOGL_ERROR, "FSM '%s' has no event names! Please fix!\n", fsm->name);
-
-	if (fsm->allstate_action && !fsm->allstate_event_mask) {
-		LOGP(DLGLOBAL, LOGL_ERROR, "FSM '%s' has allstate_action but no allstate_event_mask\n",
-			fsm->name);
-	}
-
-	if (!fsm->allstate_action && fsm->allstate_event_mask) {
-		LOGP(DLGLOBAL, LOGL_ERROR, "FSM '%s' has allstate_event_mask but no allstate_action\n",
-			fsm->name);
-	}
-
 	llist_add_tail(&fsm->list, &osmo_g_fsms);
 	INIT_LLIST_HEAD(&fsm->instances);
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14473
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idc6fcce7e946c23d48589b920e309d60aa7b6645
Gerrit-Change-Number: 14473
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190615/67794e32/attachment.html>


More information about the gerrit-log mailing list