Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: drop rudimentary vsub->cgi.lai.lac check

fixeria gerrit-no-reply at lists.osmocom.org
Sat Jun 15 11:30:43 UTC 2019


Hello laforge, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-msc/+/14465

to look at the new patch set (#2).

Change subject: libmsc/gsm_09_11.c: drop rudimentary vsub->cgi.lai.lac check
......................................................................

libmsc/gsm_09_11.c: drop rudimentary vsub->cgi.lai.lac check

This check was copy-pasted either from CC, or from SMS handling
code during the initial development of "SS/USSD over GSUP". Now
this is the only one survived after the recent refactoring.

I doubt this is exactly the right way to check whether subscriber
is attached or not. Moreover, this check should rather be done in
a single place, rather then in each CC/SS/SMS handler separately.

Change-Id: I7bd48860e923cb1f1a5bccc4b0f497ec1a7bcf84
---
M src/libmsc/gsm_09_11.c
1 file changed, 0 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/65/14465/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14465
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7bd48860e923cb1f1a5bccc4b0f497ec1a7bcf84
Gerrit-Change-Number: 14465
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190615/61ad4b7b/attachment.html>


More information about the gerrit-log mailing list