Change in ...osmo-msc[master]: gsup_client_mux_tx_error_reply(): fix: do not omit SM-RP-MR IE

laforge gerrit-no-reply at lists.osmocom.org
Sat Jun 15 08:50:02 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14456 )

Change subject: gsup_client_mux_tx_error_reply(): fix: do not omit SM-RP-MR IE
......................................................................

gsup_client_mux_tx_error_reply(): fix: do not omit SM-RP-MR IE

The SM-RP-MR (Message Reference for SM Service) value in the response
(no matter result or error) shall match the value from the request.

Change-Id: Ifb6e749928548e6febfe7768aefe9a2a3ecf4de0
---
M src/libmsc/gsup_client_mux.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/gsup_client_mux.c b/src/libmsc/gsup_client_mux.c
index 495318f..e425651 100644
--- a/src/libmsc/gsup_client_mux.c
+++ b/src/libmsc/gsup_client_mux.c
@@ -154,6 +154,9 @@
 		.cause = cause,
 		.message_type = OSMO_GSUP_TO_MSGT_ERROR(gsup_orig->message_type),
 		.message_class = gsup_orig->message_class,
+
+		/* RP-Message-Reference is mandatory for SM Service */
+		.sm_rp_mr = gsup_orig->sm_rp_mr,
 	};
 
 	OSMO_STRLCPY_ARRAY(gsup_reply.imsi, gsup_orig->imsi);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14456
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ifb6e749928548e6febfe7768aefe9a2a3ecf4de0
Gerrit-Change-Number: 14456
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190615/8da29d8f/attachment.html>


More information about the gerrit-log mailing list