Change in ...osmo-msc[master]: libmsc/gsm_0(4|9)_11_gsup.c: print error message if subscr is not known

[laforge]

laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14451 )

Change subject: libmsc/gsm_0(4|9)_11_gsup.c: print error message if subscr is not known
......................................................................

libmsc/gsm_0(4|9)_11_gsup.c: print error message if subscr is not known

Change-Id: I0b9d4128c853866d7d834f381ad520f78f441afe
Related: (TTCN-3) Id35cd3ec15d1bab15260312d7bbb41e2d10349fe
Related: OS#2931
---
M src/libmsc/gsm_04_11_gsup.c
M src/libmsc/gsm_09_11.c
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c
index a1ec634..b4d74c7 100644
--- a/src/libmsc/gsm_04_11_gsup.c
+++ b/src/libmsc/gsm_04_11_gsup.c
@@ -300,6 +300,8 @@
 	struct vlr_subscr *vsub = vlr_subscr_find_by_imsi(vlr, gsup_msg->imsi, __func__);
 
 	if (!vsub) {
+		LOGP(DLSMS, LOGL_ERROR, "Rx %s for unknown subscriber, rejecting\n",
+		     osmo_gsup_message_type_name(gsup_msg->message_type));
 		gsup_client_mux_tx_error_reply(gcm, gsup_msg, GMM_CAUSE_IMSI_UNKNOWN);
 		return -GMM_CAUSE_IMSI_UNKNOWN;
 	}
diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c
index 6558272..3de933c 100644
--- a/src/libmsc/gsm_09_11.c
+++ b/src/libmsc/gsm_09_11.c
@@ -443,6 +443,8 @@
 	struct vlr_subscr *vsub = vlr_subscr_find_by_imsi(vlr, gsup_msg->imsi, __func__);
 
 	if (!vsub) {
+		LOGP(DSS, LOGL_ERROR, "Rx %s for unknown subscriber, rejecting\n",
+		     osmo_gsup_message_type_name(gsup_msg->message_type));
 		gsup_client_mux_tx_error_reply(gcm, gsup_msg, GMM_CAUSE_IMSI_UNKNOWN);
 		return -GMM_CAUSE_IMSI_UNKNOWN;
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14451
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I0b9d4128c853866d7d834f381ad520f78f441afe
Gerrit-Change-Number: 14451
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190614/a58e11f5/attachment.htm>