Change in ...osmo-msc[master]: gsup_client_mux_tx_error_reply(): fix: do not override IMSI

laforge gerrit-no-reply at lists.osmocom.org
Fri Jun 14 21:51:58 UTC 2019


laforge has uploaded a new patch set (#2) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/14452 )

Change subject: gsup_client_mux_tx_error_reply(): fix: do not override IMSI
......................................................................

gsup_client_mux_tx_error_reply(): fix: do not override IMSI

I am not a big fan of using such syntax sugar for initializing
structures, and this is one of the reasons: it's much easier
to shoot yourself in the foot.

IMSI was copied to the new GSUP message, but then overridden.
Found using the new TC_mt_ussd_for_unknown_subscr test case.

Change-Id: If81c3fa56951185339f33a523ab6364594101be1
Related: (TTCN-3) Id35cd3ec15d1bab15260312d7bbb41e2d10349fe
Related: OS#2931
---
M src/libmsc/gsup_client_mux.c
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/52/14452/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14452
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If81c3fa56951185339f33a523ab6364594101be1
Gerrit-Change-Number: 14452
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190614/dfd54dad/attachment.html>


More information about the gerrit-log mailing list